FYST-1812 make email case insensitive for pya #5600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heroku app: https://gyr-review-app-5600-dca5b21a3cb7.herokuapp.com/ |
DrewProebstel
changed the title
mpidcock
approved these changes
Feb 19, 2025
| @@ -10,7 +10,7 @@ def update | |||
| @form = EmailAddressForm.new(email_address_form_params) | |||
|
|
|||
| if @form.valid? | |||
| archived_intake = StateFileArchivedIntake.find_by(email_address: @form.email_address) | |||
| archived_intake = StateFileArchivedIntake.where("email_address ILIKE ?", @form.email_address).first | |||
There was a problem hiding this comment.
[dust] it would be nice to be consistent with how we query both here and in the archived intake controller. either is fine, but ILIKE is a bit more esoteric, so i slightly prefer using lower for clarity
DrewProebstel
deleted the
FYST-1812-state-file-archived-intake-request-state-file-archived-intake-lookup-relies-on-matching-exact-email-instead-of-possible-capitalization-combinations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to pivotal/JIRA issue
Is PM acceptance required? (delete one)
Reminder: merge main into this branch and get green tests before merging to main
What was done?
How to test?